Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Show a warning in assets tab for permission errors #141153

Merged
merged 3 commits into from
Sep 20, 2022

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Sep 20, 2022

Summary

Resolve #134378

In the assets tab in kibana we retrieve the related saved object to an integration
When the user do not have the permissions to retrieve the Kibana saved object we show No assets this is not correct that PR fix it by showing a callout instead

UI Changes

Screen Shot 2022-09-20 at 2 42 51 PM

How to reproduce

See #134378 on how to reproduce this

@nchaulet nchaulet added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes v8.5.0 labels Sep 20, 2022
@nchaulet nchaulet self-assigned this Sep 20, 2022
@nchaulet nchaulet requested a review from a team as a code owner September 20, 2022 18:38
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Sep 20, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet nchaulet enabled auto-merge (squash) September 20, 2022 19:18
@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@nchaulet nchaulet merged commit 923fb72 into elastic:main Sep 20, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 912.7KB 913.2KB +474.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Inconsistent behavior around "Assets" tab
5 participants